-
Notifications
You must be signed in to change notification settings - Fork 62.6k
Add clarification about glob chars in branch/tag matching #8107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs weren't obvious pointing out that it's more than `*` and `**` that might need escaping when using exact matching of branch names containing these characters.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@poikilotherm Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
content/actions/reference/workflow-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poikilotherm - many thanks for raising this as an issue and for fixing it with this pull request. ✨
Once I've checked my update to your change looks okay on staging: https://docs-8107--patch-2.herokuapp.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags, I'll update your branch from main
and merge this pull request. 🚀
content/actions/reference/workflow-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Thanks for the edit, wording and merging my PR. 🤠 |
The docs weren't obvious pointing out that it's more than
*
and**
that might need escaping when using exact matching of branch names containing these characters.Why:
Closes #8106
What's being changed:
It's a very minimal change with just a few sentences, please see changed files.
Check off the following:
Writer impact (This section is for GitHub staff members only):