Skip to content

Add clarification about glob chars in branch/tag matching #8107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Jul 12, 2021

The docs weren't obvious pointing out that it's more than * and ** that might need escaping when using exact matching of branch names containing these characters.

Why:

Closes #8106

What's being changed:

It's a very minimal change with just a few sentences, please see changed files.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

The docs weren't obvious pointing out that it's more than `*` and `**` that might need escaping when using exact matching of branch names containing these characters.
@welcome
Copy link

welcome bot commented Jul 12, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 12, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 12, 2021
@ramyaparimi
Copy link
Contributor

@poikilotherm Thanks so much for opening a PR! I'll get this triaged for review ⚡

aliscco
aliscco previously approved these changes Jul 15, 2021
felicitymay
felicitymay previously approved these changes Jul 15, 2021
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poikilotherm - many thanks for raising this as an issue and for fixing it with this pull request. ✨

Once I've checked my update to your change looks okay on staging: https://docs-8107--patch-2.herokuapp.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags, I'll update your branch from main and merge this pull request. 🚀

@felicitymay felicitymay dismissed stale reviews from aliscco and themself via 17a36aa July 15, 2021 12:49
@felicitymay felicitymay enabled auto-merge (squash) July 15, 2021 12:56
@felicitymay felicitymay merged commit 008a423 into github:main Jul 15, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@poikilotherm
Copy link
Contributor Author

Thanks for the edit, wording and merging my PR. 🤠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clarification about glob chars in branch/tag matching
5 participants