Skip to content

Update using custom labels to route jobs #19625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2022
Merged

Update using custom labels to route jobs #19625

merged 2 commits into from
Aug 15, 2022

Conversation

Lehcar
Copy link
Contributor

@Lehcar Lehcar commented Aug 9, 2022 •
edited
Loading

Why:

Closes #19624

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changing the wording in one of the sentences related to custom labels and self-hosted runners to alleviate confusion.
I thought initially that the labels on the workflow job and the labels on the self-hosted runner need to match 1-1, but actually the workflow job labels just need to be a subset of the self-hosted runner labels.

I think this change will make this less confusing.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Aug 9, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
 fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@Lehcar Lehcar marked this pull request as ready for review August 9, 2022 19:48
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 10, 2022
@cmwilson21
Copy link
Contributor

👋 @Lehcar, thanks so much for opening a PR! I'll get this triaged for review ⚡

skedwards88
skedwards88 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Aug 12, 2022
@cmwilson21 cmwilson21 merged commit 45efe50 into github:main Aug 15, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Lehcar Lehcar deleted the patch-3 branch August 15, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update confusing wording on using self-hosted runners in a workflow
3 participants
@Lehcar @cmwilson21 @skedwards88