Java: use overlayChangedFiles in discard prediactes
#20049
Merged
+3
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the overlay system by replacing the extractedInOverlay predicate with the existing overlayChangedFiles predicate for determining which files should be discarded in the base variant.
- Removes the
extractedInOverlaypredicate definition - Updates discard predicates to use
overlayChangedFilesinstead ofextractedInOverlay
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java/ql/lib/semmle/code/java/Overlay.qll | Removes extractedInOverlay predicate and updates two discard predicates to use overlayChangedFiles |
| java/ql/lib/semmle/code/Location.qll | Updates location discard predicate to use overlayChangedFiles |
kaspersv
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve accuracy of overlay analysis, since we'll now correctly discard entities from files that were deleted.