C++: Add flow summaries for CreateThread and friends
#19955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fantastic! Could you approve it as well? 🙏 |
|
Yep, when the DCA run has finished (not that I'm expecting any trouble from this change). |
Sure. I promise not to merge it before the DCA run has finished (and of course, I'll check that it looks good as well), but if you want to delay the formal approval until then that's also fine with me. |
|
@geoffw0 DCA is done and looks uneventful |
jketema
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flow summaries for
CreateThread,CreateRemoteThread, andCreateRemoteThreadEx. They're all pretty much identically: We add a summary from thelpParameterto the function passed in via thelpStartAddressparameter.