CPP: Convert SQL tainted away from away from DefaultTaintTracking. #13985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts away from
DefaultTaintTracking
towards the newer API.This does end up with some changes I noticed:
argv
is repeated multiple times. This is at often 3 times (argv, *argv, **argv) + sometimes more (sometimes there seems multiple versions of some indirections?).argv
use to theargv
argument.I'm not sure about
node.asConvertedExpr()
vsasExpr
for the sink. The issue with usingasExpr
is that multiple levels of conversions are reachable without going through each over due to the references. So having fewer possible sinks seems better.I tried setting
ArgvSource
to usethis.asParameter(2)
instead ofthis.asParameter(_)
and it seems to fix these issues, but I am not sure of the consequences.