Skip to content

C++: Use FlowSource in cpp/path-injection #11638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Dec 9, 2022

Followup to #11435 now we have all relevant flow sources.

DCA looks fractionally slower. I'm not sure whether that's a concern.

MRVA with 1000 projects shows more argv related results (no results have disappeared). There's a large increase on microsoft/BlingFire (441 new results) and danmar/cppcheck (26 new results). There are 17 other projects with at most 6 new results.

@github-actions github-actions bot added the C++ label Dec 9, 2022
@jketema jketema force-pushed the rewrite-tainted-path-v2 branch from a9577a3 to 60de109 Compare December 10, 2022 19:25
@jketema jketema force-pushed the rewrite-tainted-path-v2 branch from 60de109 to beb66d0 Compare December 10, 2022 19:28
@jketema jketema marked this pull request as ready for review December 12, 2022 09:53
@jketema jketema requested a review from a team as a code owner December 12, 2022 09:53
@jketema jketema added the no-change-note-required This PR does not need a change note label Dec 12, 2022
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 🎉! I don't think the small performance change is a concern.

@MathiasVP MathiasVP merged commit b2fcf87 into github:main Dec 12, 2022
@jketema jketema deleted the rewrite-tainted-path-v2 branch December 12, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants