Deployment Confirmation #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds two new input options—deployment confirmation and its timeout—to the deployment process, including all associated tests, documentation, and schema updates.
- Introduces the deployment confirmation logic in src/functions/deployment-confirmation.js.
- Updates tests in tests/functions/deployment-confirmation.test.js, tests/main.test.js, and tests/functions/help.test.js.
- Adds new input fields and updates the Action documentation, schema, and README.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/functions/deployment-confirmation.js | Adds logic to prompt for and process deployment confirmation via reactions. |
| tests/functions/deployment-confirmation.test.js | Adds tests covering various confirmation scenarios. |
| tests/main.test.js | Updates tests to cover deployment confirmation success, failure, and input parsing error. |
| tests/schemas/action.schema.yml | Introduces new schema definitions for deployment confirmation inputs. |
| src/functions/inputs.js | Adds helper function getIntInput for parsing integer inputs. |
| action.yml, README.md, src/functions/help.js, tests/functions/help.test.js | Updates documentation and help messages to include the new inputs. |
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
northrup
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment Confirmation
This pull request introduces two new input options to toggle on/off Deployment Confirmation.
deployment_confirmation- Whether or not to require an additional confirmation before a deployment can continue. Default is "false". If your project requires elevated security, it is highly recommended to enable this option - especially in open source projects where you might be deploying forks.deployment_confirmation_timeout- The number of seconds to wait for a deployment confirmation before timing out. Default is "60" seconds (1 minute).Demo 📹
Screen.Recording.2025-03-13.at.12.46.36.PM.mov
Related: #373