Remove pyrsistent from test dependencies #4588
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not appear to be used anywhere.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4588 +/- ##
==========================================
+ Coverage 80.71% 80.72% +0.01%
==========================================
Files 156 156
Lines 16507 16507
Branches 2806 2806
==========================================
+ Hits 13323 13326 +3
+ Misses 2300 2299 -1
+ Partials 884 882 -2 |
|
“Test Common / Common (pinned) (3.9, ubuntu-22.04) (pull_request)” has “FAILED tests/test_utils.py::test_installed_modules - importlib.metadata.PackageNotFoundError: backports.asyncio.runner,” which appears unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pyrsistentdependency inrequirements-testing.txtdoes not appear to be used anywhere, so I removed it.In Fedora, I maintain the
python-pyrsistentpackage, andpython-sentry-sdkis the only thing that still depends on it. Since this dependency appears to be vestigial, my goal is to remove it both upstream and downstream and then orphanpython-pyrsistentin Fedora as an unused leaf package.