perf(connectivity): Have only one NetworkCallback active at a time #4562
+160
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
stefanosiano,
markushi and
lcian
as code owners
romtsn
commented
Jul 18, 2025
| scopes, buildInfoProvider, options.getDateProvider()); | ||
|
|
||
| final boolean registered = | ||
| AndroidConnectionStatusProvider.addNetworkCallback( |
There was a problem hiding this comment.
one caveat: This now will not emit AVAILABLE and CAPABILITIES_CHANGED callbacks immediately after registration as opposed to calling ConnectivityManager.registerDefaultNetworkCallback.
But I think it's fine and how it should be - previously any event would always start with NETWORK_AVAILABLE breadcrumb, which could have been misleading, now we're actually adding breadcrumbs whenever there's a change.
romtsn
commented
Jul 18, 2025
| if (scopes != null && options != null) { | ||
| if (scopes != null | ||
| && options != null | ||
| && status != IConnectionStatusProvider.ConnectionStatus.DISCONNECTED) { |
There was a problem hiding this comment.
kind of unrelated to this PR, but I noticed that we also submit a task even if the status was DISCONNECTED, which was unnecessary since we'd anyway bail out in the submitted task itself.
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b0bed47 | 400.72 ms | 441.62 ms | 40.90 ms |
| 4522edb | 390.10 ms | 421.50 ms | 31.40 ms |
| 551ddda | 414.94 ms | 476.12 ms | 61.19 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b0bed47 | 1.58 MiB | 2.09 MiB | 520.80 KiB |
| 4522edb | 1.58 MiB | 2.09 MiB | 520.79 KiB |
| 551ddda | 1.58 MiB | 2.09 MiB | 520.78 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Event example: https://sentry-sdks.sentry.io/issues/6560149804/events/960094050aa341cca6ac9d0c175f699e/
Replay example: https://sentry-sdks.sentry.io/explore/replays/fff819393dd44cfa9a06b54255664529
💡 Motivation and Context
Less IPC
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps