Skip to content

Fix warnings #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 8, 2018
Merged

Fix warnings #369

merged 5 commits into from
Oct 8, 2018

Conversation

jbgi
Copy link
Member

@jbgi jbgi commented Oct 7, 2018

No description provided.

@jbgi jbgi force-pushed the fixes/missing-deprecated branch from 33fae98 to f7e9c39 Compare October 7, 2018 18:15
@jbgi jbgi changed the title Add missing @Deprecated annotations (previously only on javadoc). Fix warnings Oct 7, 2018
@jbgi jbgi force-pushed the fixes/missing-deprecated branch from cf2b75b to 3f0dc3e Compare October 7, 2018 20:00
@functionaljava functionaljava deleted a comment from codecov-io Oct 7, 2018
@codecov-io
Copy link

codecov-io commented Oct 7, 2018 •
edited
Loading

Codecov Report

Merging #369 into series/4.x will increase coverage by 0.01%.
The diff coverage is 32.55%.

Impacted file tree graph

@@              Coverage Diff               @@
##           series/4.x     #369      +/-   ##
==============================================
+ Coverage       48.47%   48.48%   +0.01%     
==============================================
  Files             175      175              
  Lines            9201     9232      +31     
  Branches          524      536      +12     
==============================================
+ Hits             4460     4476      +16     
- Misses           4556     4569      +13     
- Partials          185      187       +2
Impacted Files Coverage Δ
core/src/main/java/fj/P1.java 57.57% <ø> (ø) ⬆️
core/src/main/java/fj/data/Java8.java 0% <ø> (ø)
core/src/main/java/fj/data/Java.java 26.75% <ø> (ø) ⬆️
core/src/main/java/fj/data/Collectors.java 0% <ø> (ø)
core/src/main/java/fj/data/List.java 62.32% <0%> (+0.08%) ⬆️
quickcheck/src/main/java/fj/test/Arbitrary.java 26.37% <0%> (ø) ⬆️
core/src/main/java/fj/Semigroup.java 63.88% <100%> (ø) ⬆️
quickcheck/src/main/java/fj/test/Gen.java 59.37% <100%> (ø) ⬆️
core/src/main/java/fj/data/State.java 100% <100%> (ø) ⬆️
core/src/main/java/fj/data/DList.java 100% <100%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb3263...b797968. Read the comment docs.

@jbgi jbgi changed the base branch from series/5.x to series/4.x October 8, 2018 07:59
@jbgi jbgi changed the base branch from series/4.x to series/5.x October 8, 2018 08:00
@jbgi jbgi force-pushed the fixes/missing-deprecated branch from 3f0dc3e to bef064f Compare October 8, 2018 08:14
@jbgi jbgi changed the base branch from series/5.x to series/4.x October 8, 2018 08:15
@jbgi jbgi force-pushed the fixes/missing-deprecated branch from bef064f to b797968 Compare October 8, 2018 08:21
@jbgi jbgi merged commit 921a2fd into functionaljava:series/4.x Oct 8, 2018
@jbgi jbgi added this to the 4.8.1 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbgi @codecov-io @gliptak