Skip to content

Fix compile under jdk11. Enable jdk11 travis build. #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

jbgi
Copy link
Member

@jbgi jbgi commented Sep 22, 2018

jdk11 fixes from #358 but without actually defaulting to jdk11. To minimize diff between two branches.

@codecov-io
Copy link

Codecov Report

Merging #361 into series/4.x will increase coverage by 0.13%.
The diff coverage is 48.64%.

Impacted file tree graph

@@              Coverage Diff               @@
##           series/4.x     #361      +/-   ##
==============================================
+ Coverage       48.25%   48.39%   +0.13%     
==============================================
  Files             175      175              
  Lines            9237     9200      -37     
  Branches          527      524       -3     
==============================================
- Hits             4457     4452       -5     
+ Misses           4594     4563      -31     
+ Partials          186      185       -1
Impacted Files Coverage Δ
core/src/main/java/fj/data/$.java 0% <ø> (ø) ⬆️
quickcheck/src/main/java/fj/test/reflect/Main.java 0% <ø> (ø) ⬆️
core/src/main/java/fj/data/TreeZipper.java 17.03% <0%> (+0.72%) ⬆️
core/src/main/java/fj/data/Java.java 26.75% <0%> (+0.9%) ⬆️
quickcheck/src/main/java/fj/test/Shrink.java 28.14% <0%> (ø) ⬆️
quickcheck/src/main/java/fj/test/Property.java 68.06% <0%> (+4.28%) ⬆️
...c/main/java/fj/test/runner/PropertyTestRunner.java 69.23% <100%> (-1.14%) ⬇️
quickcheck/src/main/java/fj/test/Gen.java 59.37% <100%> (ø) ⬆️
...uickcheck/src/main/java/fj/test/reflect/Check.java 44.26% <100%> (ø) ⬆️
quickcheck/src/main/java/fj/test/Cogen.java 18.07% <100%> (+0.1%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453f83c...ebdceaa. Read the comment docs.

@jbgi jbgi merged commit fb4b5bc into functionaljava:series/4.x Sep 22, 2018
@jbgi jbgi deleted the jdk11-compat branch October 7, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants