Add DList tests #356
Merged
Add DList tests #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 45.23% 45.49% +0.25%
==========================================
Files 176 176
Lines 9242 9242
Branches 527 527
==========================================
+ Hits 4181 4205 +24
+ Misses 4875 4855 -20
+ Partials 186 182 -4
Continue to review full report at Codecov.
|
jbgi
reviewed
Aug 21, 2018
| @Test | ||
| public void testListDList() { | ||
| DList<Integer> d = listDList(List.range(0, 1000)); | ||
| assertThat(d.toJavaList(), is(d.run().toJavaList())); |
There was a problem hiding this comment.
instead of testing assertThat(d.toJavaList(), is(d.run().toJavaList())); (that only check that toJavaList() is an alias of run().toJavaList()) I think we better test something like
assertThat(d.toJavaList(), is(List.range(0, 1000).toJavaList()));
(same for below methods)
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gábor Lipták gliptak@gmail.com