Skip to content

Implement Vector equals #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Implement Vector equals #350

merged 1 commit into from
Aug 9, 2018

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Aug 5, 2018

Signed-off-by: Gábor Lipták gliptak@gmail.com

@codecov-io
Copy link

codecov-io commented Aug 5, 2018

Codecov Report

Merging #350 into master will increase coverage by 0.35%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   44.26%   44.61%   +0.35%     
==========================================
  Files         176      176              
  Lines        9204     9218      +14     
  Branches      524      524              
==========================================
+ Hits         4074     4113      +39     
+ Misses       4955     4930      -25     
  Partials      175      175
Impacted Files Coverage Δ
core/src/main/java/fj/data/vector/V4.java 60% <50%> (+2.1%) ⬆️
core/src/main/java/fj/data/vector/V5.java 61.36% <50%> (+6.6%) ⬆️
core/src/main/java/fj/data/vector/V2.java 48% <50%> (+0.17%) ⬆️
core/src/main/java/fj/data/vector/V3.java 62.85% <50%> (-0.78%) ⬇️
core/src/main/java/fj/data/vector/V8.java 64.28% <50%> (+5.02%) ⬆️
core/src/main/java/fj/data/vector/V6.java 62.5% <50%> (+5.97%) ⬆️
core/src/main/java/fj/data/vector/V7.java 63.46% <50%> (+5.46%) ⬆️
core/src/main/java/fj/data/fingertrees/Deep.java 66.79% <0%> (+0.79%) ⬆️
core/src/main/java/fj/data/fingertrees/Single.java 85.18% <0%> (+3.7%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f9679...ca67637. Read the comment docs.

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@gliptak
Copy link
Contributor Author

gliptak commented Aug 6, 2018

it was tripping up on coverage ... now it is green

@jbgi jbgi merged commit 21a73c4 into functionaljava:master Aug 9, 2018
@jbgi jbgi added this to the 4.8 milestone Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants