Use service extension in networking integration test #9323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why DCM is mad. I didn't touch a single file for which a DCM warning is reported. :/ |
I think you just need to sync with the master branch - Kenzie recently updated the DCM version we are using:#9310 |
elliette
reviewed
Jul 17, 2025
| .callServiceExtensionOnMainIsolate('ext.networking_app.exit'); | ||
| logStatus(response.toString()); | ||
|
|
||
| await Future.delayed(const Duration(milliseconds: 200)); |
There was a problem hiding this comment.
What is the delayed here for? (I'm wondering if there is a future we could explicitly wait on instead...)
elliette
reviewed
Jul 17, 2025
| registerMakeRequestExtension(testServer); | ||
| } | ||
|
|
||
| void registerMakeRequestExtension(io.HttpServer testServer) { |
elliette
reviewed
Jul 17, 2025
|
|
||
| registerExtension('ext.networking_app.exit', (_, parameters) async { | ||
| unawaited( | ||
| Future.delayed(const Duration(milliseconds: 200)).then((_) => io.exit(0)), |
There was a problem hiding this comment.
Same question about delayed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a no-op. We change the communication between the integration test itself and the test app, from an HTTP connection to a VM service extension system. This vastly simplifies the test.
The motivation for this PR is to support a "test app" hot restart, in the integration test. Since this PR is quite large already, I'm saving that for the next PR.