Implement custom signal support for server side remote config #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiramanu
force-pushed
the
ssrc-custom-signals
branch
from
5fbbede to
2c9a88a
Compare
lahirumaramba
approved these changes
Jul 14, 2025
| (customSignal, targetSignal) -> customSignal.equals(targetSignal)); | ||
| case STRING_CONTAINS_REGEX: | ||
| return compareStrings(targetCustomSignalValues, customSignalValue, | ||
| (customSignal, targetSignal) -> Pattern.compile(targetSignal) |
There was a problem hiding this comment.
Does it make sense to compile and cache this (if we expect this to be used more frequently)
There was a problem hiding this comment.
Should we also wrap this in a try-catch? Could this throw java.util.regex.PatternSyntaxException?
There was a problem hiding this comment.
Skipping the caching part since the tagret signal compilation happens once for every request call. The function is moved to a try catch block where in case of error, it evaluates to false
athiramanu
force-pushed
the
ssrc-custom-signals
branch
from
2c9a88a to
af99b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.