Sourcery refactored master branch #1

sourcery-ai · 2022-03-05T08:16:34Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai

Due to GitHub API limits, only the first 60 comments can be shown.

sourcery-ai · 2022-03-05T08:16:36Z

2048/2048.py

-        elif not any(0 in row for row in self.matrix) and not self.horizontal_move_exists()\
-          and not self.vertical_move_exists():
+        elif (
+            all(0 not in row for row in self.matrix)
+            and not self.horizontal_move_exists()
+            and not self.vertical_move_exists()
+        ):


Function Game.game_over refactored with the following changes:

Invert any/all to simplify comparisons (invert-any-all)

sourcery-ai · 2022-03-05T08:16:36Z

AI_for_Guess_the_number/AI_for_Guess_the_number.py

+  print(breaking * 10);
+  a = int(input("Min: "))
+  b = int(input("Max: "))

-      else:
-          break;
-   elif(c < a):
-      print("error, number can't be smaller than min.");
-      print("Wanna go again? y for yes and anykey for no. ")
-      i = input("");
-      if(i == "y"):
-          print(breaking * 10);
+  print("now type in the number")
+  c = int(input(" "))
+  tries = 1;
+  if(a > b):
+          print("error, min can't be more than max. ")
          a = int(input("Min: "))
          b = int(input("Max: "))
-
          print("now type in the number")
          c = int(input(" "))
-          tries = 1;
-          if(a > b):
-                      print("error, min can't be more than max. ")
-                      a = int(input("Min: "))
-                      b = int(input("Max: "))
-                      print("now type in the number")
-                      c = int(input(" "))
-          else:
-            d = random.randint(a, b)
-      else:
-            break;
-   elif(d < c):
-          a = d + 1;
-          d = random.randint(a, b)
-          print( "guess " + str(tries) + " :" + str(d));
-          tries += 1;
+  else:
+    d = random.randint(a, b)
+
+ elif c > b:
+  print("error, number can't be bigger than max.");
+  print("Wanna go again? y for yes and anykey for no. ")
+  i = input("");
+  if i != "y":
+   break;
+  print(breaking * 10);
+  a = int(input("Min: "))
+  b = int(input("Max: "))
+
+  print("now type in the number")
+  c = int(input(" "))
+  tries = 1;
+  if(a > b):
+        (print("error, min can't be more than max. "))
+        a = int(input("Min: "))
+        b = int(input("Max: "))
+        print("now type in the number")
+        c = int(input(" "))
+  else:
+     d = random.randint(a, b)
+
+ elif c < a:
+  print("error, number can't be smaller than min.");
+  print("Wanna go again? y for yes and anykey for no. ")
+  i = input("");
+  if i != "y":
+   break;
+  print(breaking * 10);
+  a = int(input("Min: "))
+  b = int(input("Max: "))
+
+  print("now type in the number")
+  c = int(input(" "))
+  tries = 1;
+  if(a > b):
+              print("error, min can't be more than max. ")
+              a = int(input("Min: "))
+              b = int(input("Max: "))
+              print("now type in the number")
+              c = int(input(" "))
+  else:
+    d = random.randint(a, b)
+ elif d < c:
+  a = d + 1;
+  d = random.randint(a, b)
+  print(f"guess {tries} :{str(d)}");
+  tries += 1;

-   elif(d > c):
-      b = d - 1;
-      d = random.randint(a, b)
-      print( "guess " + str(tries) + " :" + str(d))  
-      tries += 1
+ elif d > c:
+  b = d - 1;
+  d = random.randint(a, b)
+  print(f"guess {tries} :{str(d)}")
+  tries += 1


Lines 9-124 refactored with the following changes:

Swap if/else branches (swap-if-else-branches)

Remove unnecessary else after guard condition (remove-unnecessary-else)

Use f-string instead of string concatenation (use-fstring-for-concatenation)

Remove unnecessary calls to str() from formatted values in f-strings (remove-str-from-fstring)

sourcery-ai · 2022-03-05T08:16:36Z

Algebra-Solver/Algebra-Solver.py

-	print("X = " + str(X))
+	print(f"X = {str(X)}")


Function main refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-03-05T08:16:36Z

CSV-to-Excel/main.py

-#rows and columns
-row = 1
 column = 1

 #for each line in the file
-for line in file:
+for row, line in enumerate(file, start=1):


Lines 26-46 refactored with the following changes:

Move assignment closer to its usage within a block (move-assign-in-block)

Replace manual loop counter with call to enumerate (convert-to-enumerate)

This removes the following comments ( why? ):

#rows and columns

sourcery-ai · 2022-03-05T08:16:36Z

Checksum/checksum.py

-    signature = base64.b64encode(digest).decode("utf-8")
-    return signature
+    return base64.b64encode(digest).decode("utf-8")


Function sign refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-03-05T08:16:38Z

Cryptocurrency-converter/CryptoConverter.py

-                self.result = round(self.result, 2)
-                self.label_2.setText(str(self.result))
            else:
                self.result = int(self.new_label) * self.api(self.cur1, self.cur2)
-                self.result = round(self.result, 2)
-                self.label_2.setText(str(self.result))
+            self.result = round(self.result, 2)
+            self.label_2.setText(str(self.result))


Function MainWindow.convert_fun refactored with the following changes:

Hoist repeated code outside conditional statement (hoist-statement-from-if)

sourcery-ai · 2022-03-05T08:16:38Z

Current_City_Weather/Weather.py

-    temp_in_celcius = json_data['main']['temp']
-    return temp_in_celcius
+    return json_data['main']['temp']


Function get_temperature refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-03-05T08:16:39Z

Current_City_Weather/Weather.py

-    weather_type = json_data['weather'][0]['description']
-    return weather_type
+    return json_data['weather'][0]['description']


Function get_weather_type refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-03-05T08:16:39Z

Current_City_Weather/Weather.py

-    wind_speed = json_data['wind']['speed']
-    return wind_speed
+    return json_data['wind']['speed']


Function get_wind_speed refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-03-05T08:16:39Z

Directory_Tree_Generator/directory_tree_generator.py

-        name = name.replace(char, "\\" + char)
+        name = name.replace(char, f"\\{char}")


Function escape_illegal refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-03-05T08:16:42Z

Download-page-as-pdf/download-page-as-pdf.py

-        name = name + '.pdf'
+        name = f'{name}.pdf'


Function main refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-03-05T08:16:42Z

Excel_Files_Merger/Combine excel files into 1.py

-        row_data = []
-        for cell in row:
-            row_data.append(cell.value)
+        row_data = [cell.value for cell in row]


Function reader refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

sourcery-ai · 2022-03-05T08:16:42Z

Excel_to_ListofList/ExcelToList.py

-			currentlist = []
-			for current_col in range(start_col,numberofcols):
-				currentlist.append(inputsheet.cell(current_row,current_col).value)
+			currentlist = [
+			    inputsheet.cell(current_row, current_col).value
+			    for current_col in range(start_col, numberofcols)
+			]


Function ExcelToList.convert refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

sourcery-ai · 2022-03-05T08:16:42Z

File-Explorer-Dialog-Box/select_file_pyqt.py

-	print("You selected:\n", "\n".join(filename for filename in filenames))
+	print("You selected:\n", "\n".join(filenames))


Function main refactored with the following changes:

Simplify generator expression (simplify-generator)

sourcery-ai · 2022-03-05T08:16:42Z

File-Organizer/file-organizer.py

- 
+
 #The Path of the directory to be sorted
 path = 'C:\\Users\\<USERNAME>\\Downloads'
 #This populates a list with the filenames in the directory
 list_ = os.listdir(path)
- 
+


Lines 3-24 refactored with the following changes:

Hoist repeated code outside conditional statement (hoist-statement-from-if)

Use f-string instead of string concatenation (use-fstring-for-concatenation)

This removes the following comments ( why? ):

#If the directory does not exist, it creates a new directory #If a directory with the name 'ext' exists, it moves the file to that directory

sourcery-ai · 2022-03-05T08:16:44Z

File_Carving/carving.py

-	print(f'\nSEARCH RESULT: %d Files. %d Directory.' % (file_cnt, dir_cnt))
+	print('\\nSEARCH RESULT: %d Files. %d Directory.' % (file_cnt, dir_cnt))


Lines 88-88 refactored with the following changes:

Replace f-string with no interpolated values with string (remove-redundant-fstring)

sourcery-ai · 2022-03-05T08:16:44Z

Find-PhoneNumber-in-String/Find-PhoneNumber-in-String.py

-    for i in range(0, 3):
+    for i in range(3):


Function check_phone_number refactored with the following changes:

Simplify boolean if expression (boolean-if-exp-identity)

Replace range(0, x) with range(x) (remove-zero-from-range)

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2022-03-05T08:16:44Z

Find-PhoneNumber-in-String/Find-PhoneNumber-in-String.py

-        print('Phone number has been found! : ' + split)
+        print(f'Phone number has been found! : {split}')


Lines 24-24 refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-03-05T08:16:44Z

Folder Locker & Hider/locker.py

-	command1 = 'ren ' + fname + ' "Control Panel.{21EC2020-3AEA-1069-A2DD-' + key + '}"'
+	command1 = (
+	    f'ren {fname}' + ' "Control Panel.{21EC2020-3AEA-1069-A2DD-' + key + '}"')
 	command2 = 'attrib +h +s "Control Panel.{21EC2020-3AEA-1069-A2DD-' + key + '}"'

 	dct = read_json()

-	if not fname in dct.keys():
+	if fname not in dct.keys():


Function lock refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

Simplify logical expression using De Morgan identities (de-morgan)

sourcery-ai · 2022-03-05T08:16:44Z

Folder Locker & Hider/locker.py

-		status = 'unlocked'
+		return 'unlocked'
 	else:
-		status = 'failed'
-
-	return status
+		return 'failed'


Function unlock refactored with the following changes:

Lift return into if (lift-return-into-if)

sourcery-ai · 2022-03-05T08:16:47Z

Folder_Manager/Folder_Manager.py

@@ -24,7 +24,6 @@ def folder_manager(path,exception_file,extensions):
        if type( extensions) is not list:
            raise Exception('Expected a list object.')
        extensions = set( extensions)
-


Function folder_manager refactored with the following changes:

Hoist repeated code outside conditional statement (hoist-statement-from-if)

Merge nested if conditions (merge-nested-ifs)

Remove redundant continue statement (remove-redundant-continue)

sourcery-ai · 2022-03-05T08:16:47Z

Github_Bot/main.py

-        url = self.base_url + "users/" + args[0]
+        url = f'{self.base_url}users/{args[0]}'


Function GithubBot.get_user_details refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-03-05T08:16:48Z

Github_Bot/main.py

-        url = self.base_url + "repos/" + args[0] + "/" + args[1]
+        url = f'{self.base_url}repos/{args[0]}/{args[1]}'


Function GithubBot.get_repo_details refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-03-05T08:16:48Z

HTML_Table_to_List/HTMLTableToList.py

-			current_row = []
 			all_th  = tr.findAll('th')
 			all_td  = tr.findAll('td')
-			for th in all_th:
-				current_row.append(th.text)
-			for td in all_td:
-				current_row.append(td.text)
+			current_row = [th.text for th in all_th]
+			current_row.extend(td.text for td in all_td)


Function HTMLTableToList.get_list refactored with the following changes:

Move assignment closer to its usage within a block (move-assign-in-block)

Convert for loop into list comprehension (list-comprehension)

Replace a for append loop with list extend (for-append-to-extend)

sourcery-ai · 2022-03-05T08:16:48Z

IMDBQuerier/film_content_parser.py

-    return ''.join(found_numbers[0:4])
+    return ''.join(found_numbers[:4])


Function parse_film_year refactored with the following changes:

Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (remove-redundant-slice-index)

sourcery-ai · 2022-03-05T08:16:50Z

PX-to-REM/px_to_rem.py

-    if value == 'Q' or value == 'q':
+    if value in ['Q', 'q']:
        user_selected(value)
-    elif value == 'C' or value == 'c':
+    elif value in ['C', 'c']:
        if (callback.__name__ == 'process_px_to_rem'):
            process_rem_to_px()
-            return
        else:
            process_px_to_rem()
-            return
+        return


Function process_check refactored with the following changes:

Replace multiple comparisons of same variable with in operator (merge-comparisons)

Hoist repeated code outside conditional statement (hoist-statement-from-if)

sourcery-ai · 2022-03-05T08:16:50Z

PX-to-REM/px_to_rem.py

-    if user_input == 'A' or user_input == 'a': # PX to REM
+    if user_input in ['A', 'a']: # PX to REM
        process_px_to_rem()
-    elif user_input == 'B' or user_input == 'b': # REM to PX
+    elif user_input in ['B', 'b']: # REM to PX
        process_rem_to_px()
-    elif user_input == 'Q' or user_input == 'q':
+    elif user_input in ['Q', 'q']:


Function user_selected refactored with the following changes:

Replace multiple comparisons of same variable with in operator (merge-comparisons)

sourcery-ai · 2022-03-05T08:16:50Z

Pressure_Converter/pressure_converter_script.py

-    if unit == "atm":
-        bar = float(atm) * 1.01325
-        return bar
-    else:
-        return "Invalid unit"
+    return float(atm) * 1.01325 if unit == "atm" else "Invalid unit"


Function atmospeheres_to_bars refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-03-05T08:16:51Z

Pressure_Converter/pressure_converter_script.py

-    if unit == "bar":
-        atm = float(bar) / 1.01325
-        return atm
-    else:
-        return "Invalid unit"
+    return float(bar) / 1.01325 if unit == "bar" else "Invalid unit"


Function bars_to_atmospheres refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-03-05T08:16:51Z

Pressure_Converter/pressure_converter_script.py

-    if unit == "atm":
-        mm_hg = float(atm) * 760
-        return mm_hg
-    else:
-        return "Invalid unit"
+    return float(atm) * 760 if unit == "atm" else "Invalid unit"


Function atmospheres_to_milimeter_mercury refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-03-05T08:17:01Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 0.19%.

Quality metrics	Before	After	Change
Complexity	11.44 🙂	10.76 🙂	-0.68 👍
Method Length	54.69 ⭐	53.82 ⭐	-0.87 👍
Working memory	8.33 🙂	8.37 🙂	0.04 👎
Quality	65.18% 🙂	65.37% 🙂	0.19% 👍

Other metrics	Before	After	Change
Lines	6041	5855	-186

Changed files	Quality Before	Quality After	Quality Change
2048/2048.py	76.50% ⭐	76.51% ⭐	0.01% 👍
AI_for_Guess_the_number/AI_for_Guess_the_number.py	16.41% ⛔	18.61% ⛔	2.20% 👍
Algebra-Solver/Algebra-Solver.py	95.78% ⭐	95.73% ⭐	-0.05% 👎
CSV-to-Excel/main.py	65.35% 🙂	63.29% 🙂	-2.06% 👎
Checksum/checksum.py	63.33% 🙂	63.47% 🙂	0.14% 👍
Codechef-Code-Submitter/automated-submission.py	73.55% 🙂	73.41% 🙂	-0.14% 👎
Color_to_BW_Converter/bw_convert.py	83.93% ⭐	83.93% ⭐	0.00%
Contact-Distribution/contact-distribution.py	59.37% 🙂	62.13% 🙂	2.76% 👍
Crypt_Socket/cryptSocket_cliente.py	71.25% 🙂	71.08% 🙂	-0.17% 👎
Crypt_Socket/cryptSocket_servidor.py	64.00% 🙂	64.13% 🙂	0.13% 👍
Cryptocurrency-Prices/cryptocurrency-prices.py	74.94% 🙂	74.83% 🙂	-0.11% 👎
Cryptocurrency-converter/CryptoConverter.py	85.01% ⭐	85.81% ⭐	0.80% 👍
Current_City_Weather/Weather.py	90.09% ⭐	90.16% ⭐	0.07% 👍
Directory_Tree_Generator/directory_tree_generator.py	64.78% 🙂	64.76% 🙂	-0.02% 👎
Download-page-as-pdf/download-page-as-pdf.py	73.05% 🙂	72.93% 🙂	-0.12% 👎
Excel_Files_Merger/Combine excel files into 1.py	82.23% ⭐	83.09% ⭐	0.86% 👍
Excel_to_ListofList/ExcelToList.py	79.01% ⭐	78.29% ⭐	-0.72% 👎
File-Explorer-Dialog-Box/select_file_pyqt.py	95.89% ⭐	96.89% ⭐	1.00% 👍
File-Organizer/file-organizer.py	70.24% 🙂	73.21% 🙂	2.97% 👍
File-Sharing-Bot/bot.py	78.41% ⭐	78.31% ⭐	-0.10% 👎
File_Carving/carving.py	68.06% 🙂	69.03% 🙂	0.97% 👍
Find-PhoneNumber-in-String/Find-PhoneNumber-in-String.py	76.82% ⭐	78.99% ⭐	2.17% 👍
Folder Locker & Hider/locker.py	75.10% ⭐	75.45% ⭐	0.35% 👍
Folder_Manager/Folder_Manager.py	45.79% 😞	47.63% 😞	1.84% 👍
Github_Bot/main.py	81.64% ⭐	81.59% ⭐	-0.05% 👎
HTML_Table_to_List/HTMLTableToList.py	80.26% ⭐	84.62% ⭐	4.36% 👍
IMDBQuerier/film_content_parser.py	77.84% ⭐	75.76% ⭐	-2.08% 👎
IMDBQuerier/html_creator.py	93.28% ⭐	94.58% ⭐	1.30% 👍
IMDBQuerier/main.py	67.03% 🙂	65.76% 🙂	-1.27% 👎
IMDBQuerier/parser_config.py	82.76% ⭐	82.51% ⭐	-0.25% 👎
Image-Circulator/image_circulator.py	53.77% 🙂	53.57% 🙂	-0.20% 👎
Image_Compressor/Image_Compressor.py	88.78% ⭐	88.61% ⭐	-0.17% 👎
InstadpShower/dppage.py	69.98% 🙂	69.83% 🙂	-0.15% 👎
Minecraft_server_in_background/run.py	66.97% 🙂	67.41% 🙂	0.44% 👍
PX-to-REM/px_to_rem.py	82.96% ⭐	87.41% ⭐	4.45% 👍
Pressure_Converter/pressure_converter_script.py	88.83% ⭐	90.70% ⭐	1.87% 👍
Proxy-Request/proxy_request.py	80.93% ⭐	80.88% ⭐	-0.05% 👎
PyRecorder/py_recorder.py	76.59% ⭐	75.61% ⭐	-0.98% 👎
Py_Cleaner/main.py	44.77% 😞	46.81% 😞	2.04% 👍
RSA_Algorithm/RSA_algorithm.py	27.34% 😞	27.19% 😞	-0.15% 👎
RSA_Communication/RSA.py	70.62% 🙂	71.14% 🙂	0.52% 👍
Random_Email_Generator/Random_email_generator.py	81.09% ⭐	81.17% ⭐	0.08% 👍
Random_Names_Generator/Random_Name_Generator.py	83.05% ⭐	83.05% ⭐	0.00%
Random_Password_Generator/PasswordGenerator.py	39.71% 😞	44.79% 😞	5.08% 👍
Random_Password_Generator/createPassword.py	91.18% ⭐	91.18% ⭐	0.00%
Remove-Duplicate-Files/removeDuplicateFiles.py	60.95% 🙂	63.28% 🙂	2.33% 👍
Rock-Paper-Scissor/Rock-Paper-Scissor.py	73.27% 🙂	74.13% 🙂	0.86% 👍
SSH_Host_Adder/ssh_adder.py	90.56% ⭐	90.56% ⭐	0.00%
SimpleWebpageParser/SimpleWebpageParser.py	96.55% ⭐	97.12% ⭐	0.57% 👍
Slideshare-Downloader/slideshare_downloader.py	83.09% ⭐	83.03% ⭐	-0.06% 👎
SmsYourLocation/SmsYourLocation.py	78.08% ⭐	78.08% ⭐	0.00%
Squid-Proxy-Installer-for-Ubuntu16/Squid_Proxy.py	76.84% ⭐	78.15% ⭐	1.31% 👍
Steg_Tool/steg.py	15.46% ⛔	16.74% ⛔	1.28% 👍
Subtitle-downloader/main.py	85.10% ⭐	85.06% ⭐	-0.04% 👎
Tambola_Ticket_Generator/main.py	87.18% ⭐	86.19% ⭐	-0.99% 👎
TicTacToe_AI_and_2_players/TicTacToe2players.py	74.28% 🙂	74.14% 🙂	-0.14% 👎
TicTacToe_AI_and_2_players/TicTacToeAI.py	52.83% 🙂	56.39% 🙂	3.56% 👍
TicTacToe_AI_and_2_players/TicTacToeVsAI.py	73.55% 🙂	73.55% 🙂	0.00%
To Do Bot/bot.py	53.28% 🙂	50.89% 🙂	-2.39% 👎
To Do Bot/dbhelper.py	91.20% ⭐	91.68% ⭐	0.48% 👍
TranslateCLI/Translate.py	79.50% ⭐	80.70% ⭐	1.20% 👍
Tweets_Tool/Tool.py	50.54% 🙂	50.94% 🙂	0.40% 👍
Website-Blocker/website_blocker.py	41.63% 😞	46.03% 😞	4.40% 👍
Website_Url_Detector/detect_urls.py	89.49% ⭐	89.39% ⭐	-0.10% 👎
Word-generator/gen.py	82.36% ⭐	82.52% ⭐	0.16% 👍
Word_Frequency_Counter/count_word_freq.py	81.99% ⭐	81.92% ⭐	-0.07% 👎
Work_Log_Generator/work_log.py	77.56% ⭐	77.70% ⭐	0.14% 👍
asymmetric_cryptography/asymmetric.py	83.39% ⭐	82.58% ⭐	-0.81% 👎
automated_email/automated_email.py	49.50% 😞	49.97% 😞	0.47% 👍
codeforcesChecker/checker.py	55.60% 🙂	55.72% 🙂	0.12% 👍
codeforcesChecker/main.py	58.55% 🙂	56.40% 🙂	-2.15% 👎
csv_to_json/convert.py	65.15% 🙂	64.89% 🙂	-0.26% 👎
elastic-snapshot/elastic-snapshot.py	56.17% 🙂	55.99% 🙂	-0.18% 👎
file-encrypt-decrypt/crypt.py	77.30% ⭐	77.35% ⭐	0.05% 👍
git_automation/create.py	90.03% ⭐	89.94% ⭐	-0.09% 👎
imageWatermarker/main.py	66.84% 🙂	66.67% 🙂	-0.17% 👎
images2pdf/imges2pdf.py	61.28% 🙂	62.66% 🙂	1.38% 👍
imdb_episode_ratings/scraper.py	57.56% 🙂	55.70% 🙂	-1.86% 👎
insta_video_downloader/instavideo.py	52.90% 🙂	58.92% 🙂	6.02% 👍
json-to-yaml/json2yaml.py	60.34% 🙂	61.10% 🙂	0.76% 👍
logpye_log4j_search/logpye.py	66.28% 🙂	67.73% 🙂	1.45% 👍
medium_article_downloader/helpers.py	77.81% ⭐	76.42% ⭐	-1.39% 👎
medium_article_downloader/medium.py	73.23% 🙂	73.49% 🙂	0.26% 👍
send_sqs_messages_in_parallel/send_to_sqs.py	82.45% ⭐	88.82% ⭐	6.37% 👍
send_whatsapp_message/whatsapp-message.py	69.98% 🙂	69.98% 🙂	0.00%
spotify_downloader/spotify.py	71.84% 🙂	72.19% 🙂	0.35% 👍
sudoku-solver/sudoku_solver/solver.py	70.50% 🙂	71.90% 🙂	1.40% 👍
vigenere_cipher/vigenere.py	63.49% 🙂	63.58% 🙂	0.09% 👍
yts_torrents/yts_am_api.py	48.00% 😞	48.75% 😞	0.75% 👍
zabbix_api/dailyAlertMail.py	72.98% 🙂	72.76% 🙂	-0.22% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
Steg_Tool/steg.py	encode	58 ⛔	384 ⛔	17 ⛔	9.95% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
Steg_Tool/steg.py	decode	47 ⛔	277 ⛔	17 ⛔	14.48% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
To Do Bot/bot.py	handle_updates	39 ⛔	330 ⛔	17 ⛔	14.88% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
Tweets_Tool/Tool.py	TweetManager.getTweets	24 😞	344 ⛔	19 ⛔	19.84% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
Py_Cleaner/main.py	clean_dir	21 😞	238 ⛔	13 😞	32.12% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

'Refactored by Sourcery'

2580086

sourcery-ai bot requested a review from eysteing March 5, 2022 08:16

sourcery-ai bot commented Mar 5, 2022

View reviewed changes

		name = name.replace(char, "\\" + char)
		name = name.replace(char, f"\\{char}")

		print("You selected:\n", "\n".join(filename for filename in filenames))
		print("You selected:\n", "\n".join(filenames))

		print(f'\nSEARCH RESULT: %d Files. %d Directory.' % (file_cnt, dir_cnt))
		print('\\nSEARCH RESULT: %d Files. %d Directory.' % (file_cnt, dir_cnt))

		print('Phone number has been found! : ' + split) No newline at end of file
		print(f'Phone number has been found! : {split}')

		url = self.base_url + "users/" + args[0]
		url = f'{self.base_url}users/{args[0]}'

		url = self.base_url + "repos/" + args[0] + "/" + args[1]
		url = f'{self.base_url}repos/{args[0]}/{args[1]}'

		return ''.join(found_numbers[0:4])
		return ''.join(found_numbers[:4])

Sourcery refactored master branch #1

Are you sure you want to change the base?

Sourcery refactored master branch #1

Uh oh!

Conversation

sourcery-ai bot commented Mar 5, 2022

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 5, 2022