Use 'url' template filter in docs #6805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
reviewed
Jul 16, 2019
| </li> | ||
|
|
||
| {% for toc_item in toc_item.children %} | ||
| <li> | ||
| <a href="{{ toc_item.url }}">{{ toc_item.title }}</a> | ||
| <a href="{{ toc_item.url|url }}">{{ toc_item.title }}</a> |
There was a problem hiding this comment.
Turns out we only wanted this on the main nav
There was a problem hiding this comment.
I guess it wouldn't ever be useful, since the toc items are just fragments, right? A toc item would never navigate to another URL. Agh, I swear I checked the side nav to see if this change affected them. 🤦♂
There was a problem hiding this comment.
Hm. TOC seemed to have work locally? ¯\_(ツ)_/¯
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixes #6803