Case insensitive uniqueness validation #4534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation can be case insensitive
|
I think I'd rather move |
tomchristie
requested changes
Oct 4, 2016
| @@ -42,10 +42,11 @@ class UniqueValidator(object): | |||
| """ | |||
| message = _('This field must be unique.') | |||
|
|
|||
| def __init__(self, queryset, message=None): | |||
| def __init__(self, queryset, message=None, ignore_case=True): | |||
There was a problem hiding this comment.
I'd probably prefer to see us do this by adding a lookup="exact" parameter here that can be modified.
Make it more explicit what's going on under the hood.
| self.queryset = queryset | ||
| self.serializer_field = None | ||
| self.message = message or self.message | ||
| self.ignore_case = ignore_case |
| @@ -62,7 +63,8 @@ def filter_queryset(self, value, queryset): | |||
| """ | |||
| Filter the queryset to all instances matching the given attribute. | |||
| """ | |||
| filter_kwargs = {self.field_name: value} | |||
| field_lookup = 'iexact' if self.ignore_case else 'exact' | |||
| filter_kwargs = {'%s__%s' % (self.field_name, field_lookup): value} | |||
There was a problem hiding this comment.
'%s__%s' % (self.field_name, self.lookup)
|
@tomchristie have made the requested changes and added a test |
tomchristie
approved these changes
Oct 4, 2016
|
Great stuff! |
|
Thanks for the quick response on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes fields need to be validated as unique in a case insensitive manner, e.g. a usernames. This PR adds a
ignore_caseargument toUniqueValidatorwhich causes the queryset lookup to useiexact.Haven't added any tests yet - wanted to first see if you think this is useful and the right approach.