Updated test (to fail) to show coreapi schema generator does not generate links for all methods on multimethod list_routes #4448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxiao
changed the title
shangxiao
force-pushed
the
failing-test-for-multimethod-list-route
branch
from
a345a9a to
b0521a5
Compare
shangxiao
changed the title
shangxiao
force-pushed
the
failing-test-for-multimethod-list-route
branch
from
b0521a5 to
2bc9c8f
Compare
shangxiao
changed the title
…rate links for all methods on multimethod list_routes
shangxiao
force-pushed
the
failing-test-for-multimethod-list-route
branch
from
2bc9c8f to
242c491
Compare
| @@ -99,6 +99,10 @@ def test_anonymous_request(self): | |||
| url='/example/custom_list_action/', | |||
| action='get' | |||
| ), | |||
| 'custom_list_action': coreapi.Link( | |||
There was a problem hiding this comment.
Note that it wouldn't be valid to have a dictionary with the same key repeated twice.
There was a problem hiding this comment.
Whoops, must've been before my coffee… 😬
Perhaps the option here is to have a list for the custom_list_action key. Or a dict of action-links.
|
Closed via #4529. Incoming in version 3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoreAPI schema generator does not seem to generate all the necessary
Linkelements for multimethodlist_routeviews.