v.2.0 (clean arch) #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 83.80% 84.55% +0.74%
==========================================
Files 1 16 +15
Lines 142 356 +214
==========================================
+ Hits 119 301 +182
- Misses 17 47 +30
- Partials 6 8 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…eparate function)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot reviewed 47 out of 48 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (1)
internal/adapters/filechecker_test.go:11
- Relying on a hardcoded file path ("./filechecker.go") can lead to inconsistent test results in different environments. Consider creating a temporary file within the test to reliably verify file existence.
{"FileChecker: exists", "./filechecker.go", true},
There was a problem hiding this comment.
Copilot reviewed 47 out of 48 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (1)
internal/adapters/filetemper.go:5
- [nitpick] The name 'FileTemper' might be ambiguous; consider renaming it to 'FileTemp' or 'TempFile' for clarity.
type FileTemper struct {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by Copilot:
This pull request includes various updates and refactors to improve the functionality and maintainability of the codebase. The most important changes include updates to the GitHub Actions workflow, modifications to the
Makefile, refactoring of the main application logic, and the introduction of new adapters and their corresponding tests.Workflow and Build Improvements:
.github/workflows/go.yml: Updated the GitHub Actions workflow to use the latest versions of actions and tools, and added depth fetching for checkout.Makefile Enhancements:
Makefile: Added new commands for running end-to-end tests with remote Markdown and HTML files, and improved thelintandtestcommands to cover all directories. [1] [2]Application Logic Refactoring:
cmd/gh-md-toc/main.go: Refactored the main application logic to use the newapp.Configstructure and removed redundant functions for processing paths and standard input. [1] [2] [3]ghdoc.goandghtoc.go: Removed the oldGHDocandGHTocimplementations, which have been replaced by new adapters and configurations. [1] [2]New Adapters and Tests:
internal/adapters/filechecker.goandinternal/adapters/filechecker_test.go: Added a file checker adapter to verify file existence. [1] [2]internal/adapters/filetemper.goandinternal/adapters/filetemper_test.go: Added a file temper adapter for creating temporary files. [1] [2]internal/adapters/filewriter.goandinternal/adapters/filewriter_test.go: Added a file writer adapter to handle file writing operations. [1] [2]internal/adapters/htmlconverter.goandinternal/adapters/htmlconverter_test.go: Added an HTML converter adapter to convert Markdown files to HTML. [1] [2]Logger Enhancements:
internal/adapters/logger.goandinternal/adapters/logger_test.go: Added a new logger adapter to handle logging with configurable debug mode. [1] [2]