Skip to content

Onboarding: Remove temporary pixel for visit site CTA #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Onboarding: Remove temporary pixel for visit site CTA #6379

wants to merge 1 commit into from
+0 −36

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jul 11, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/1176956903599313/task/1209716934407463?focus=true

Description

Remove temporary pixel count for visit site onboarding dialog

Steps to test this PR

Context Visit Site onboarding dialog

  • Fresh install
  • Once in the browser, tap on a search suggestion
  • Dismiss SERP dialog
  • In-context Visit Site dialog is shown
  • Logcat: Check onboarding_visit_site_cta_shown pixel is not fired

In-context Visit Site onboarding dialog

  • Fresh install
  • Once in the browser, tap on a search suggestion
  • Open a new tab
  • Context Visit Site dialog is shown
  • Logcat: Check onboarding_visit_site_cta_shown pixel is not fired

No UI changes

@nalcalag Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag force-pushed the feature/noelia/remove_pixel_visit_site_cta branch from 3183b44 to 4eed29e Compare July 18, 2025 10:37
@nalcalag nalcalag marked this pull request as ready for review July 18, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikescamell mikescamell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalcalag @mikescamell