adding mentionTrigger #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mentionSuggestions: mentionSuggestionsStyles.mentionSuggestions, | ||
|
|
There was a problem hiding this comment.
The spaces where here by intention to make it easy to distinct which component is affected. Maybe a comment would have been better. Can you add comments?
There was a problem hiding this comment.
I didn't realize I made these changes. I'll add some comments.
| @@ -1,9 +1,8 @@ | |||
| /* @flow */ | |||
|
|
|||
| import findWithRegex from 'find-with-regex'; | |||
| import _ from 'lodash'; | |||
There was a problem hiding this comment.
This is not ideal, as it would include the whole lodash library. By using import escapeRegExp from 'lodash/escapeRegExp' we can reduce the imported code and skip all other lodash code not necessary for this plugin.
|
Some related improvements here #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #253 (comment).
Adds
mentionTriggertoconfigwith default value of@.Adds and searches for mention entities with key of
'mention' + mentionTriggermentionStrategyandmentionSuggestionsStrategytakes the trigger as a parameter.Feedback welcome