Hook arguments #172
Hook arguments #172
Conversation
|
Seems like a good move and very much inline with what I'd expect from the hooks; we won't always need every argument and we can always decide to add more arguments without breaking anything. No objection 👍 |
|
+1 for this change, but I still don't see how this is better than passing the |
|
@ianstormtaylor I talked to Isaac and none of the public methods are supposed to be used by people except I wonder if there is a use-case that would require to expose the |
|
I'm all for restriction by default. All good things are better with a smaller API Julian Krispel-Samsel
|
This will make plugin system more flexible for future changes.
In the future we can easily extend out the arguments depending on new features that will be available in DraftJS. We even could pass in the whole pluginEditor context (as we had it in the first implementation & @ianstormtaylor suggested) and it would not result in a braking the API.
Yet I don't feel comfortable to expand the API and pass down the whole pluginEditor context until there is a valid use-case.
focus()came up as a suggestion, but this can easily be done withforceSelectionon the editorState as well.I'm curious how you guys feel about it? @juliankrispel @ianstormtaylor @bkniffler
P.S. I merged it already so I can move on with some refactoring. If there are good arguments against this change I'm happy to revert back.