[Review] Refactor event listeners #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juliankrispel can you check why travis fails? |
…ners, added comment to pluginProps thing
juliankrispel
force-pushed
the
refactor-event-listeners
branch
from
990bb32 to
1983df4
Compare
|
bloody style :) I squashed the commits into one... |
| createEventListeners = () => { | ||
| const listeners = { | ||
| onChange: this.onChange, | ||
| editorState: this.editorState, |
There was a problem hiding this comment.
Doesn't make sense for editorState to be in the listeners section since it's just data.
There was a problem hiding this comment.
fair point, the variable name should be different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first pr to change how event listeners are attached to Editor
fixes #144
cc @nikgraf @ianstormtaylor