Skip to content

Add register command for .csx file registration #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2019
Merged

Add register command for .csx file registration #431

merged 5 commits into from
Apr 3, 2019

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Mar 31, 2019 •
edited
Loading

Added command to platform register .csx files using following command:
dotnet-script register
To resolve bug #430

Tom Laird-McConnell and others added 5 commits March 31, 2019 15:47
Add command for .csx file registration
0a93a69 
This was removed, adding back as optional operation that can be invoked from command line
tweak to use dotnet script instead of dotnet exec dll pattern
5724f1f 
This makes the registration version independent
fix typo in command
f376a52
Merge branch 'master' into master
77f06ed
@seesharper
Merge branch 'master' into master
af4f2bf
seesharper
seesharper approved these changes Apr 3, 2019
View reviewed changes
Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The reason that we removed this as an implicit operation was that it was considered a little too intrusive in the case that the user had another application associated with *.csx

@seesharper
Copy link
Collaborator

Thanks 👍

@seesharper seesharper merged commit fccd336 into dotnet-script:master Apr 3, 2019
@seesharper seesharper mentioned this pull request Apr 3, 2019
Closed
@CBielstein CBielstein mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seesharper seesharper seesharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomlm @seesharper