Skip to content

set .net cli environment variables in CI #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Conversation

filipw
Copy link
Member

@filipw filipw commented Apr 10, 2018

Improve CI build performance.
Do not build up package cache + do not send telemetry from CI.

@filipw filipw requested a review from seesharper April 10, 2018 07:27
Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. LGTM

@seesharper seesharper merged commit bcdaa66 into master Apr 10, 2018
@seesharper seesharper deleted the feature/ci-variables branch April 10, 2018 08:14
@atifaziz
Copy link
Contributor

Improve CI build performance.

Is this measurable? I'm curious to know if it made a remarkable impact on build times (as in going from X to Y minutes where Y < X).

@filipw
Copy link
Member Author

filipw commented Apr 10, 2018

when you opt out from first time experience, the global cache doesn't get populated. it takes ~50s to populate it
http://donovanbrown.com/post/Stop-wasting-time-during-NET-Core-builds

@atifaziz
Copy link
Contributor

@filipw Thanks and I was precisely looking for that text quoted by @DarqueWarrior on his blog post:

A command is running to initially populate your local package cache, to improve restore speed and enable offline access. This command will take up to a minute to complete and will only happen once.

I didn't find it on previous builds in the build history (AppVeyor/Travis), taking a recent build for b390197 as an example. Then I would have expected that it disappeared in the build for this PR. It could be that the images used AppVeyor and Travis have the cache primed so those build are not considered first-time runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants