Skip to content

Do not cast when refactoring 'foreach var' #49120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2020
Merged

Do not cast when refactoring 'foreach var' #49120

merged 2 commits into from
Nov 30, 2020

Conversation

huoyaoyuan
Copy link
Member

Fixes #48950. Replaces #49100.

Not bothering so much - just testing the most common case.

@huoyaoyuan huoyaoyuan requested a review from a team as a code owner November 2, 2020 08:37
@huoyaoyuan
Copy link
Member Author

Out of time failure :(

@huoyaoyuan huoyaoyuan closed this Nov 2, 2020
@huoyaoyuan huoyaoyuan reopened this Nov 2, 2020
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Nov 2, 2020
@mavasani mavasani merged commit 195cc4b into dotnet:master Nov 30, 2020
@ghost ghost added this to the Next milestone Nov 30, 2020
@huoyaoyuan huoyaoyuan deleted the foreach-var branch December 1, 2020 06:44
@dibarbet dibarbet modified the milestones: Next, 16.9.P3 Dec 19, 2020
@mikadumont mikadumont mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavasani mavasani mavasani approved these changes

Assignees

@mavasani mavasani

Labels
Area-Analyzers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.9.P3
Development

Successfully merging this pull request may close these issues.

Don't cast when converting foreach loop to for loop unless necessary
5 participants
@huoyaoyuan @mavasani @dibarbet @jinujoseph @Dotnet-GitSync-Bot