-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Social SDK: Add OAuth Communications Scope warnings #7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* [Presence & Rich Presence](/docs/discord-social-sdk/core-concepts#presence-rich-presence) | ||
|
||
The Social SDK provides the helper method [`Client::GetDefaultPresenceScopes`], which returns `openid sdk.social_layer_presence`, | ||
that you can use when setting up your OAuth2 flow, for integrations that only needs the above functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that you can use when setting up your OAuth2 flow, for integrations that only needs the above functionality. | |
that you can use when setting up your OAuth2 flow, for integrations that only need the above functionality. |
Not sure which is grammatically correct but I think this reads better
Devs keep running into the issue that they aren't aware that to use communication features, they need to enable communication OAuth scopes (mainly because we're not explicit about it anywhere). This aims to fix this! This PR includes: - Reorganize core concepts page to prioritize OAuth scopes - Add implementation details to OAuth guide - Add warnings to guides using Communications features about scope requirements
5378035
to
e1e1637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
### Default Communication Scopes | ||
|
||
The communications features are currently available but have limited access. Those features **require** the following scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The communications features are currently available but have limited access. Those features **require** the following scope | |
The communications features are currently available but have limited access. Those features **require** the scope |
I think this reads a little better
bf901ec
to
23190e5
Compare
* Social SDK: Add OAuth Communications Scope warnings Devs keep running into the issue that they aren't aware that to use communication features, they need to enable communication OAuth scopes (mainly because we're not explicit about it anywhere). This aims to fix this! This PR includes: - Reorganize core concepts page to prioritize OAuth scopes - Add implementation details to OAuth guide - Add warnings to guides using Communications features about scope requirements * Review updates.
Devs keep running into the issue that they aren't aware that to use communication features, they need to enable communication OAuth scopes (mainly because we're not explicit about it anywhere).
This aims to fix this! This PR includes: