Skip to content

Document role gradient colors #7549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 26, 2025
Merged

Document role gradient colors #7549

merged 13 commits into from
Jun 26, 2025
+77 −32

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented May 9, 2025 •
edited by anthonydiscord
Loading

Adds documentation for the role's gradient colors

@DA-344 DA-344 requested a review from a team as a code owner May 9, 2025 14:52
@DA-344 DA-344 requested review from anthonydiscord and removed request for a team May 9, 2025 14:52
AlmostSuspense
AlmostSuspense reviewed May 9, 2025
View reviewed changes
@DA-344 @AlmostSuspense
typo on permissions.md
99b2a50 
Co-authored-by: Suspense <64612795+AlmostSuspense@users.noreply.github.com>
@LonelyDeathVGX LonelyDeathVGX mentioned this pull request May 9, 2025
Open
@Lulalaby
Copy link
Contributor

Lulalaby commented May 9, 2025

I might be wrong here, but it seems like the holographic style needs the following config:
primary (11127295), secondary (16759788), tertiary (16761760)
And tertiary can't be set for normal gradients.

I haven't tested around enough, but that was my impression

@advaith1
Copy link
Member

I assumed that was a client only restriction, is it enforced server side?

@rayakame rayakame mentioned this pull request May 11, 2025
Open
@sebm253 sebm253 mentioned this pull request May 12, 2025
Merged
1 task
@anthonydiscord anthonydiscord added the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label May 19, 2025
@DA-344
Copy link
Contributor Author

DA-344 commented May 27, 2025

I might be wrong here, but it seems like the holographic style needs the following config: primary (11127295), secondary (16759788), tertiary (16761760) And tertiary can't be set for normal gradients.

I haven't tested around enough, but that was my impression

I also haven't tested enough with the holographic style, but afaik the restriction was only enforced on client side - similar to how channel cooldowns used to be in it

@Paillat-dev Paillat-dev mentioned this pull request Jun 22, 2025
Open
9 tasks
@DA-344 DA-344 mentioned this pull request Jun 22, 2025
Merged
6 tasks
@advaith1
Copy link
Member

turns out the holographic role colors are validated. this needs to be documented

@anthonydiscord anthonydiscord removed the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Jun 24, 2025
anthonydiscord
anthonydiscord requested changes Jun 25, 2025
View reviewed changes
DA-344 and others added 3 commits June 25, 2025 09:14
@DA-344 @anthonydiscord
Reword info block on RoleColors
44fbc45 
Co-authored-by: Anthony <anthony.tesija@discordapp.com>
@DA-344 @anthonydiscord
's
d393bd6 
Co-authored-by: Anthony <anthony.tesija@discordapp.com>
@DA-344
Update based on the review
4697b9e
@DA-344 DA-344 requested a review from anthonydiscord June 25, 2025 07:35
anthonydiscord
anthonydiscord requested changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@anthonydiscord anthonydiscord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed one more spot for changes and then this looks good to me! Thanks again for taking the time to do this

@DA-344 @anthonydiscord
's
dc32e77 
Co-authored-by: Anthony <anthony.tesija@discordapp.com>
@sdanialraza sdanialraza mentioned this pull request Jun 25, 2025
Merged
@anthonydiscord
Copy link
Contributor

Make sure to run npm run test:links to figure out which links aren't formatted properly and then npm run fix:tables when you're done to auto format the tables

@DA-344
Copy link
Contributor Author

DA-344 commented Jun 26, 2025

Make sure to run npm run test:links to figure out which links aren't formatted properly and then npm run fix:tables when you're done to auto format the tables

Done

@anthonydiscord
Copy link
Contributor

Amazing!! Thanks again for the in depth contribution!

@anthonydiscord anthonydiscord merged commit be4846c into discord:main Jun 26, 2025
4 checks passed
Snazzah added a commit to Snazzah/slash-create that referenced this pull request Jun 27, 2025
@Snazzah
feat: add role gradient support
9f1ff20 
Ref: discord/discord-api-docs#7549
@ooliver1 ooliver1 mentioned this pull request Jun 28, 2025
Open
3 tasks
@sdanialraza sdanialraza mentioned this pull request Jul 1, 2025
Merged
@Fleny113 Fleny113 mentioned this pull request Jul 3, 2025
Merged
mazylol pushed a commit to mazylol/discord-api-docs that referenced this pull request Jul 3, 2025
@DA-344 @AlmostSuspense
@anthonydiscord @mazylol
Document role gradient colors (discord#7549)
1b0e92b 
* feat: document role gradient colors

* object

* comma

* features and more clear docs

* tables

* typo on permissions.md

Co-authored-by: Suspense <64612795+AlmostSuspense@users.noreply.github.com>

* add note about holographic style

* Reword info block on RoleColors

Co-authored-by: Anthony <anthony.tesija@discordapp.com>

* 's

Co-authored-by: Anthony <anthony.tesija@discordapp.com>

* Update based on the review

* 's

Co-authored-by: Anthony <anthony.tesija@discordapp.com>

* apply suggestions and fix tables

---------

Co-authored-by: Suspense <64612795+AlmostSuspense@users.noreply.github.com>
Co-authored-by: Anthony <anthony.tesija@discordapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlmostSuspense AlmostSuspense AlmostSuspense left review comments

@anthonydiscord anthonydiscord anthonydiscord approved these changes

Assignees

@anthonydiscord anthonydiscord

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DA-344 @Lulalaby @advaith1 @anthonydiscord @AlmostSuspense