-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Document user guild tags #6836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document user guild tags #6836
Conversation
90296f0
to
ee625de
Compare
Will there be an option for server owners to disable showing clan tags in their server? I feel like messages would get quite cluttered otherwise, especially for servers completely unrelated to gaming. |
Agreed, that should be definitely kept in mind.
Additionally, to have a clan badge next to it would fill the whole author line probably at some point. |
Why was this naming convention approved? This is going to cause a ton of confusion for every new developer. Now we have two naming discrepancies that are even conflicting. Server -> Guild and Guild -> Clan. I'm really disappointed in this decision and dread the amount of confusion this will cause. |
Hey everyone, I'm one of the engineering leads of the team testing this feature out. We understand the confusion around guilds and server terminology. This is just an experiment at this time. If we decide to roll this out more broadly after the experiment concludes, we intend to come up with a better name that will be consistent across our Developer API and how we refer to it in the product. We know this might cause some confusion while the experiment is live and intend to clean things up soon. Thanks! |
curious, but why some fields in {
"type": 0,
"tts": false,
"timestamp": "2024-05-19T17:21:27.550000+00:00",
"pinned": false,
"mentions": [],
"mention_roles": [],
"mention_everyone": false,
"id": "1241802919326646283",
"flags": 0,
"embeds": [],
"edited_timestamp": null,
"content": "haven't seen you in a while",
"components": [],
"channel_id": "1241787241014104136",
"author": {
"username": "pukima",
"public_flags": 4194432,
"id": "751092600890458203",
"global_name": "Pukima",
"discriminator": "0",
"clan": {
"tag": null,
"identity_guild_id": null,
"identity_enabled": false,
"badge": null
},
"avatar_decoration_data": {
"sku_id": "1144307629225672846",
"asset": "a_d72066b8cecbadd9fc951913ebcc384f"
},
"avatar": "b7e2f5461e61512674abc06c3d0264b7"
},
"attachments": []
} |
docs/resources/User.md
Outdated
@@ -59,6 +60,12 @@ There are other rules and restrictions not shared here for the sake of spam and | |||
"accent_color": 16711680, | |||
"premium_type": 1, | |||
"public_flags": 64 | |||
"clan": { | |||
"identity_guild_id": "1234647491267808778", | |||
"identity_enabled": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if they've disabled identity shouldn't this whole clan object just not be serialized?
@devsnek when this will add? |
https://support.discord.com/hc/en-us/articles/23187611406999-Guilds-FAQ
|
That aged like fine milk |
It's not wrong though.
Gaming Guilds themselves haven't returned (I assume fully scrapped); and their enforced 200-member limit you can just manually recreate yourself easily via revoking Create Invite permission & deleting all Invites when your Server hits that member count. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this here as updated information for the skill_tree feature "Server Tag".
tl;dr: primary_guild
is the new field; clan
is deprecated but most likely still in the api for backwards compatibility
gif is not possible for the badge
Note
The table formatting won't fit anymore because it's a web review
Cheers!
Any update on when this is going to get merged? Just as |
6fc2a80
to
eb40fbc
Compare
eb40fbc
to
96a6b93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
docs/resources/user.mdx
Outdated
| Field | Type | Description | | ||
|-------------------|------------|---------------------------------------------------------------| | ||
| identity_guild_id | ?snowflake | the id of the user's primary guild | | ||
| identity_enabled | ?boolean | whether the user is displaying the primary guild's server tag | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really do think the behaviour of this being null
meaning a new identity hasn't been affirmed should be documented. It is very unclear otherwise.
docs/reference.mdx
Outdated
@@ -353,6 +353,7 @@ Discord uses ids and hashes to render images in the client. These hashes can be | |||
| Role Icon | role-icons/[role_id](/docs/topics/permissions#role-object)/[role_icon](/docs/topics/permissions#role-object).png | PNG, JPEG, WebP | | |||
| Guild Scheduled Event Cover | guild-events/[scheduled_event_id](/docs/resources/guild-scheduled-event#guild-scheduled-event-object)/[scheduled_event_cover_image](/docs/resources/guild-scheduled-event#guild-scheduled-event-object).png | PNG, JPEG, WebP | | |||
| Guild Member Banner | guilds/[guild_id](/docs/resources/guild#guild-object)/users/[user_id](/docs/resources/user#user-object)/banners/[member_banner](/docs/resources/guild#guild-member-object).png \* | PNG, JPEG, WebP, GIF | | |||
| Server Tag Badge | clan-badges/[guild_id](/docs/resources/guild#guild-object)/[badge_hash](/docs/resources/user#user-object-user-primary-guild).png \* | PNG, JPEG, WebP | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the asterisk is doing here, as this does not support GIFs, and the asterisk isn't present in the icon routes for example. Just to improve clarity.
* [primary guild] Add documentation for user primary guild. * Fix links * "object" * Update badge path and add null identity_enabled explainer. * Clarify null case * Update guild tag badge name * Fix tables --------- Co-authored-by: Kirby Cool <kirbydcool@gmail.com> Co-authored-by: advaith <advaithj1@gmail.com>
Guilds can adopt a server tag and allow users to adopt the guild's tag as their own. This tag is displayed in
the client next to their name.
This documents the server tags that might come down on the user object.