Skip to content

Migrate logging tests to gtest. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2013
Merged

Migrate logging tests to gtest. #11

merged 1 commit into from
Jan 26, 2013

Conversation

imaginaryboy
Copy link

No description provided.

@deanberris
Copy link
Owner

LGTM

However, I would love to convert these ASSERT_TRUE( x == y) into ASSERT_EQ(x, y) instead. I'll merge this and hope we can do another cleanup of other tests.

Thanks Martin!

deanberris added a commit that referenced this pull request Jan 26, 2013
@deanberris deanberris merged commit a7892e1 into deanberris:gtest-migration Jan 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants