Skip to content

Fix for boost 1.70 (get_io_service() was deprecated and was removed) #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2019
Merged

Fix for boost 1.70 (get_io_service() was deprecated and was removed) #878

merged 6 commits into from
Aug 12, 2019

Conversation

enricodetoma
Copy link

get_io_service() was removed in Boost 1.70.

I made a pull request using the alternative get_executor().context()

@enricodetoma
Copy link
Author

I forgot to keep compatibility with older ASIO versions. Now the pull request should be ok.

Copy link
Member

@deanberris deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @enricodetoma!

Please find comments below.

Copy link
Member

@deanberris deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more requests and I think we're almost there... :)

Copy link
Member

@deanberris deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @enricodetoma!

@deanberris deanberris merged commit 2bef8be into cpp-netlib:0.13-release Aug 12, 2019
yogev-lb added a commit to LightBitsLabs/osmosis that referenced this pull request Mar 23, 2023
using the following patch:

cpp-netlib/cpp-netlib#878

to update support for new boost.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants