-
Notifications
You must be signed in to change notification settings - Fork 425
Fix for boost 1.70 (get_io_service() was deprecated and was removed) #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for boost 1.70 (get_io_service() was deprecated and was removed) #878
Conversation
I forgot to keep compatibility with older ASIO versions. Now the pull request should be ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @enricodetoma!
Please find comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more requests and I think we're almost there... :)
boost/network/protocol/http/client/connection/connection_delegate_factory.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @enricodetoma!
using the following patch: cpp-netlib/cpp-netlib#878 to update support for new boost.
get_io_service()
was removed in Boost 1.70.I made a pull request using the alternative
get_executor().context()