Skip to content

Bugfix: register signal handler before starting the server #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Bugfix: register signal handler before starting the server #864

merged 1 commit into from
Nov 26, 2018

Conversation

mtrenkmann
Copy link

This PR defers the execution of server.run(), which is blocking, until the signal handler has been registered.

@mtrenkmann
Copy link
Author

This PR is safe to merge. It does not affect any CI builds.

Copy link
Member

@deanberris deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@deanberris deanberris merged commit 8cafe88 into cpp-netlib:master Nov 26, 2018
@mtrenkmann mtrenkmann deleted the fix-echo-async-server-example branch November 26, 2018 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants