Fix issue with Microsoft's checked iterators #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Avoids an issue with Microsoft's checked iterators and is likely more correct/portable.
|
LGTM -- thanks @LoopinFool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After grabbing the latest 0.13-release to sync up with Boost 1.67, I ran into a big issue in my debug build.
I constantly hit an assert in the checked iterators so had to track it down and fix it.
The current code casts iterators from the partial_parsed buffer (which can be quite large) to iterators for the small temporary std::array buffer. MS implemented their checked iterators using the statically-declared size of the array (which is much smaller than partial_parsed) so they hit all the time.
Also, that static_cast likely only worked because compilers likely use char* as the iterator type for both containers, but I don't think assuming that is portable.
I changed chunk_encoding_parser so that its operator() and update_chunk_size can take any compatible iterator_range type as arguments.