Skip to content

Directives: remove parens to silence gcc8 warning #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coneiric
Copy link

Fixes -Wparentheses warning from gcc8 builds for 0.13-release branch.

Example build output:

cpp-netlib/boost/network/protocol/http/message/directives/status_message.hpp:17:1: note: in expansion of macro 'BOO
ST_NETWORK_STRING_DIRECTIVE'                                                                                                                
 BOOST_NETWORK_STRING_DIRECTIVE(status_message, status_message_,                                                                            
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                                                             
cpp-netlib/boost/network/message/directives/detail/string_directive.hpp:37:21: warning: unnecessary parentheses in 
declaration of 'uri_' [-Wparentheses]                                                                                                       
     ValueType const&((value));

@coneiric coneiric force-pushed the fix-gcc8-paren-warning-0.13r branch from 3dcaaad to 0b8ab04 Compare May 31, 2018 03:38
@coneiric coneiric force-pushed the fix-gcc8-paren-warning-0.13r branch from 0b8ab04 to 2421e1d Compare June 13, 2018 19:53
@coneiric
Copy link
Author

coneiric commented Jul 2, 2018

Hello @deanberris, is there something keeping this PR from being merged?

@deanberris
Copy link
Member

Nothing -- sorry for the delay, and thanks for the reminder!

@deanberris deanberris merged commit 38e48c9 into cpp-netlib:0.13-release Jul 2, 2018
@coneiric
Copy link
Author

coneiric commented Jul 3, 2018

No worries, thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants