fix client_get_streaming_test #840
Conversation
| @@ -26,7 +26,7 @@ struct body_handler { | |||
| TYPED_TEST_CASE(HTTPClientTest, ClientTypes); | |||
|
|
|||
| TYPED_TEST(HTTPClientTest, GetStreamingTest) { | |||
| typename TypeParam::request request("http://www.boost.org"); | |||
| typename TypeParam::request request("https://www.boost.org"); | |||
There was a problem hiding this comment.
Thanks, @yhager -- we probably want to only build this particular test now if we've enabled HTTPS support. Can you try making this whole test conditional on whether the BOOST_NETWORK_ENABLE_HTTPS macro is defined?
There was a problem hiding this comment.
This should be much simpler to do:
#if BOOST_NETWORK_ENABLE_HTTPS
TYPED_TEST(HTTPClientTest, GetStreamingTest) {
...
}
#endifThere was a problem hiding this comment.
No problem. Pushed the change you requested. Sorry for misunderstanding what you meant.
| client_get_ready_test) | ||
| if (OPENSSL_FOUND) | ||
| list(APPEND TESTS client_get_streaming_test) | ||
| endif() |
There was a problem hiding this comment.
I don't think this is what I meant.
The client_get_streaming_test could have just skipped building the GetStreamingTest by checking whether the BOOST_NETWORK_ENABLE_HTTPS as a preprocessor macro. Please revert this part of the PR.
| @@ -26,7 +26,7 @@ struct body_handler { | |||
| TYPED_TEST_CASE(HTTPClientTest, ClientTypes); | |||
|
|
|||
| TYPED_TEST(HTTPClientTest, GetStreamingTest) { | |||
| typename TypeParam::request request("http://www.boost.org"); | |||
| typename TypeParam::request request("https://www.boost.org"); | |||
There was a problem hiding this comment.
This should be much simpler to do:
#if BOOST_NETWORK_ENABLE_HTTPS
TYPED_TEST(HTTPClientTest, GetStreamingTest) {
...
}
#endif
| @@ -26,7 +26,7 @@ struct body_handler { | |||
| TYPED_TEST_CASE(HTTPClientTest, ClientTypes); | |||
|
|
|||
| TYPED_TEST(HTTPClientTest, GetStreamingTest) { | |||
| typename TypeParam::request request("http://www.boost.org"); | |||
| typename TypeParam::request request("https://www.boost.org"); | |||
* fix client_get_streaming_test * perform client_get_streaming_test only if SSL is enabled * test for BOOST_NETWORK_ENABLE_HTTPS for https streaming test
fixes #836