Skip to content

Enable remove_chunk_markers by default. Fix a bug and add a comment. #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

igorpeshansky
Copy link

No description provided.

@igorpeshansky
Copy link
Author

@deanberris PTAL.
@umennel FYI.

Copy link
Member

@deanberris deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deanberris deanberris merged commit 540ed76 into cpp-netlib:master Mar 15, 2018
@deanberris
Copy link
Member

Thanks, @igorpeshansky -- would it make sense if you merge these into 0.13-release as well? It may not be a straight-forward merge.

@igorpeshansky
Copy link
Author

@deanberris Did you mean both #720 and #830?

@deanberris
Copy link
Member

@igorpeshansky Yes, both those would be good to see in 0.13-release.

@umennel
Copy link

umennel commented Mar 31, 2018

Cherry-picked commits from both PRs with #833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants