Skip to content

Do not wrap exceptions passed to boost::promise::set_exception in std… #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

HighCommander4
Copy link

…::exception_ptr (fixes #815)

boost::promise only knows about boost::exception_ptr, and handles
wrapping of concrete exception types into that itself. If passed
std::exception_ptr, it will wrap it a second time and later throw
the std::exception_ptr itself.

…::exception_ptr (fixes cpp-netlib#815)

boost::promise only knows about boost::exception_ptr, and handles
wrapping of concrete exception types into that itself. If passed
std::exception_ptr, it will wrap it a second time and later throw
the std::exception_ptr itself.
Copy link
Member

@deanberris deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @HighCommander4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants