content_length type comparison error #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit f8ff77d. It is also initialized to -1 in parse_headers_real(...). Signed-off-by: Edward Kigwana <ekigwana@gmail.com>
deanberris
reviewed
Apr 6, 2017
There was a problem hiding this comment.
Thanks @ekigwana -- it's not a blocker, but have you thought about how hard it would be if we used an optional<size_t> instead for the content length? That way we don't need to do funny things with casting the value.
If that's going to take longer or more effort then I'm fine with this in the meantime.
|
I have not looked at it but it seems easy enough to do. I'll need a few days. Put this request on hold for a bit please. |
|
LGTM That's fine to do after, I'm happy to merge this in the meantime. :) |
deanberris
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type was std::size_t and was changed to long long in commit f8ff77d. It is also initialized to
-1 in parse_headers_real(...) to help determine parse error.
Signed-off-by: Edward Kigwana ekigwana@gmail.com