Skip to content

Make this work with Boost 1.55. #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

igorpeshansky
Copy link

No description provided.

@deanberris
Copy link
Member

Just curious (and I know we haven't been able to remove the Boost dependencies yet) but have you tested with later Boost releases? Also curious why you need this to work with 1.55.

@@ -10,7 +10,7 @@

#define BOOST_SPIRIT_UNICODE
#include <boost/spirit/include/qi.hpp>
#include <boost/fusion/include/std_tuple.hpp>
#include <boost/fusion/adapted/std_tuple.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still work with later Boost versions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should (this header is present in 1.63 and on what seems to be the development branch).

@deanberris
Copy link
Member

LGTM

@deanberris deanberris merged commit 21624f2 into cpp-netlib:master Apr 4, 2017
@igorpeshansky
Copy link
Author

I don't see why it wouldn't, but I'll test tomorrow.
As for why I need older boost versions, 1.55 is the default on older Ubuntu, and we'd much rather not package our own shared libs. Our stuff might even need to work on Wheezy and CentOS 6 (gasp!), so I may end up going even lower than 1.55.
This change, however, simply removes a gratuitous version bound, as cpp-netlib doesn't seem to be requiring any newer boost features.

@deanberris
Copy link
Member

That's fair -- although we do use C++11 features where we can, and I know of older compilers having issues with C++11. If we're going to need to support older compilers, then a pre-C++11 build (0.11.x) would be preferred, though there's a huge delta between then and the current state of the library in 0.13-devel and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants