ICC fixes #738
Merged
ICC fixes #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanberris
requested changes
Mar 1, 2017
| @@ -131,7 +131,7 @@ class basic_client_facade { | |||
| } else { | |||
| if (boost::empty(content_type_headers)) { | |||
| typedef typename char_<Tag>::type char_type; | |||
| static char_type content_type[] = "x-application/octet-stream"; | |||
| static char_type* content_type = "x-application/octet-stream"; | |||
There was a problem hiding this comment.
I suppose a better change here would be:
static char_type const content_type[] = "...";
|
Updated. |
|
LGTM -- thanks @eile! |
Merged
|
@deanberris your requested change actually does not work, at least with icc 17: I suggest to keep the initial code change by @eile: I just verified that this compiles. |
|
@tribal-tec -- that's interesting, why isn't this an ICC bug? If you send me a pull request I'd be happy to review and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const-qualify function-local static constant arrays.