add client size close for #712 #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanberris
requested changes
Dec 1, 2016
| this->part_begin; | ||
| typename protocol_base::buffer_type::const_iterator end = begin; | ||
| std::advance(end, remainder); | ||
| string_type body_string(begin, end); |
There was a problem hiding this comment.
Do you even need this copy of the string? Why not use the range instead?
| @@ -476,6 +495,50 @@ struct http_async_connection | |||
| } | |||
| } | |||
|
|
|||
| inline bool check_parse_body_complete(string_type& body_string) | |||
There was a problem hiding this comment.
It looks like you could avoid using strings here, and just deal with ranges of iterators.
chenzhaoyu
force-pushed
the
add-active-client-side-close
branch
from
4fc7dda to
b950ea5
Compare
|
@deanberris , thanks for your comments, I have move body check logic to async_protocol_handler.hpp and no extra body buffer be copied now, please check, thanks~ |
|
Hi, @deanberris , can you merge those commits from master into 0.13-release branch? |
cnagune
added a commit
to cnagune/cpp-netlib
that referenced
this pull request
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempt to fix #712 , if response body is completed, client side will close connection.
Comments are welcome!
regards,
chenzhaoyu