Skip to content

Boost future master #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 14, 2016
Merged

Conversation

dvd0101
Copy link

@dvd0101 dvd0101 commented Oct 15, 2016

This is #684 against the master branch

it does not compile now
boost::shared_future has a richer api, notably it has the `is_ready()`
method required by the `ready()` wrapper
@dvd0101 dvd0101 force-pushed the boost_future_master branch from 281cb0c to d7bec0a Compare October 15, 2016 16:45
@glynos
Copy link
Member

glynos commented Oct 15, 2016

All tests on Travis failed.

@cinghiale ignore the tests for clang right now, we already now that they don't work. However, it looks like you have added a dependency to Boost.System to cpp-netlib, and their is a linking error for the tests and examples.

@dvd0101
Copy link
Author

dvd0101 commented Oct 17, 2016

Added the missing libraries. Waiting for the CI...

@dvd0101
Copy link
Author

dvd0101 commented Oct 17, 2016

Still some failures... I'll try to fix soon

@dvd0101
Copy link
Author

dvd0101 commented Nov 1, 2016

@glynos I'm a bit puzzled by the failings. Looking at the output it looks like we found an ICE in one of the tests:

[ 90%] Building CXX object libs/network/test/http/CMakeFiles/cpp-netlib-http-server_async_run_stop_concurrency.dir/server_async_run_stop_concurrency.cpp.o
[snip]
g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions.

On my ubuntu box (16.10) I have access to gcc 4.8.5 and it compiles fine.

any suggestion is very appreciated

@deanberris
Copy link
Member

I think we don't need to block this on the CI results. We should be able to fix this after the fact.

@deanberris
Copy link
Member

LGTM

@deanberris deanberris merged commit f1e6cb8 into cpp-netlib:master Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants