Skip to content

replace std::shared_future with boost::shared_future #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2016

Conversation

dvd0101
Copy link

@dvd0101 dvd0101 commented Sep 18, 2016

This PR replaces std::promise and std::shared_future with boost equivalents.

This change fixes the compilation errors when the ready() wrapper is used.

I've added a test and a few words of documentation.

This should address #683 and #592

it does not compile now
boost::shared_future has a richer api, notably it has the `is_ready()`
method required by the `ready()` wrapper
@deanberris
Copy link
Member

@cinghiale -- looks like the tests have failed, can you please have a look to see why?

@dvd0101
Copy link
Author

dvd0101 commented Sep 19, 2016

@deanberris it looks like a timeout of the install_boost script, I don't think it is related. How can I trigger a rebuild? Are you ok with an empty commit?

@dvd0101
Copy link
Author

dvd0101 commented Sep 19, 2016

The test timeout during the boost installation; any idea?

@deanberris
Copy link
Member

I remember this being an issue back then -- I'm not sure exactly how I resolved this, but it's a limitation of the Travis runners. So this might not be something you @cinghiale can fix. 😦

I'll defer to @glynos on whether to merge this with minimal testing. But I'm certainly fine with something that, if it works for you, is good enough to merge.

There's probably a more updated way of installing a more recent Boost installation now without having to rebuild it every time (and relying on the cache) but I've not time to have a look.

@glynos glynos merged commit 9835d24 into cpp-netlib:0.13-release Sep 24, 2016
@glynos
Copy link
Member

glynos commented Sep 24, 2016

I merged it into 0.13-release, but I haven't fixed the failures on clang on Travis. I'll be away for a few days and take another look later next week.

Thanks for your contribution, @cinghiale!

@dvd0101
Copy link
Author

dvd0101 commented Oct 9, 2016

I notice that this PR has not yet been merged on master.

If you want I can take care of the fixes needed to apply it on the master and then proceed with a new PR.

@deanberris
Copy link
Member

@cinghiale -- I think @glynos and I would prefer seeing another PR just for the master branch. Since we don't merge back changes manually to master, and since this may not apply cleanly even then.

Thanks!

@dvd0101 dvd0101 mentioned this pull request Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants