Skip to content

Do not assume ipv4 for source #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Conversation

deanberris
Copy link
Member

Fixes #611 -- this does not assume that address() is always convertible to ipv4.

@glynos
Copy link
Member

glynos commented Mar 9, 2016

There is no associated test?

@deanberris
Copy link
Member Author

Merging now.

Apparently @glynos had a comment.

There's really no way to test this currently as far as I can tell, at least without running a server which listens on an ipv6 address.

@deanberris
Copy link
Member Author

@glynos Can we merge it now first, then make sure this is tested at a later date when we're refactoring the implementations? I'd be happy to do it, but I think just addressing the issue right now this way should work.

glynos added a commit that referenced this pull request Mar 9, 2016
@glynos glynos merged commit 3ceb0e3 into cpp-netlib:master Mar 9, 2016
@deanberris deanberris deleted the ipv6-support branch March 9, 2016 21:53
@deanberris
Copy link
Member Author

Thanks @glynos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants