[#600] Add TLS SNI hostname to client options #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new member and API to
http::client::options
for an optional TLS SNI hostname. HTTPS client option callsites may optionally support/provide an SNI hostname:The implementation within
ssl_delegate
andsync_ssl
arrive at an OpenSSL (and equivalent API implementations):SSL_set_tlsext_host_name
. See the OpenSSL wiki for TLS SNI details, as well as usage examples.Also, there are various non-thesis related style changes pulled in via
clang-format
and the project's local format file. Please let me know if it is unacceptable to piggy-back these changes and I will try to remove them. Most of my editors auto-format so pulling out the changes is doable. 🙀 😉