Update boost to std #589
Merged
Update boost to std #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, and Travis is green! Thanks @glynos -- I'll have a look soon! |
|
I see you've removed the Twitter example -- did we need to update anything from the docs for that? Just wondering, I don't think we need to make the change now. |
|
LGTM -- skimmed it, and I'm happy that Travis is green. Thanks again @glynos! |
|
I didn't update any documentation. We should go through that anyway, because I think it is out-od-date in a lot of ways. twiitter_search has been a bit of an embarrassment because it just crashed, that's why I removed it completely. We need better examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deanberris
I took the leap ... as far as I possibly could I replaced boost classes/functions with their C++11/14 equivalents.
There's still a lot to do. I did not touch the code that depends on MPL/type traits because I think this should be eventually replaced (all the message stuff).
The thread pool still uses boost::thread_group, but I think it would be trivial to implement it ourselves (therefore we won't need to link to boost thread at all). As for the other boost static libraries, they are really only needed for some dependencies and for the examples.
Also, I did not touch the cpp-netlib MIME code (I don't know what to do with it, though I suspect it would continue to work if we used C++11/14 here).
Eventually I want to be able to build cpp-netlib without an external dependency to boost or asio. We can later use the boost-free asio, and for the rest a shrink-wrapped (header-only) boost.
Let's talk on slack if you want more info.