Fixed libraries to link, so ld will not fail on Linux with missing DSO #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,7 +95,7 @@ if (Boost_FOUND) | |||
| ws2_32 wsock32) | |||
| endif() | |||
| if (${CMAKE_SYSTEM_NAME} MATCHES "Linux") | |||
| target_link_libraries(cpp-netlib-http-server_async_run_stop_concurrency rt) | |||
| target_link_libraries(cpp-netlib-http-server_async_run_stop_concurrency pthread rt) | |||
There was a problem hiding this comment.
This is partially correct, but I think the more correct change would be to add ${CMAKE_THREAD_LIBS_INIT} to line 87 instead. Can you make that change to see whether that fixes it?
Fixed libraries to link, so ld will not fail on Linux with: 'missing DSO' because of missing libpthread.
|
@deanberris You were right, that worked. |
|
LGTM Awesome, thanks @susnux -- I'll wait for the integration tests to finish then merge this in. Cheers |
deanberris
added a commit
that referenced
this pull request
Jan 10, 2016
Fixed libraries to link, so ld will not fail on Linux with missing DSO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on openSUSE building of cpp-netlib (tests) fails with:
missing DSO on commandline.This happens due to missing pthread on target_link_libraries for cpp-netlib-http-server_async_run_stop_concurrency test.