Setting source port #551
Merged
Setting source port #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,6 +112,10 @@ struct basic_request : public basic_message<Tag> { | |||
| void uri(string_type const& new_uri) const { uri_ = new_uri; } | |||
|
|
|||
| boost::network::uri::uri const& uri() const { return uri_; } | |||
|
|
|||
| void setSourcePort(const unsigned short port) { source_port_ = port; } | |||
There was a problem hiding this comment.
Please rename this as source_port instead to follow the convention already set in the class.
|
Just a couple of comments, sorry for the very long delay @DanielBujnik -- I'm usually better about these things. 😏 |
|
Thanks for feedback. Getter and setter methods are now named as source_port as requested. |
| @@ -110,6 +112,10 @@ struct basic_request : public basic_message<Tag> { | |||
| void uri(string_type const& new_uri) const { uri_ = new_uri; } | |||
|
|
|||
| boost::network::uri::uri const& uri() const { return uri_; } | |||
|
|
|||
| void source_port(const unsigned short port) { source_port_ = port; } | |||
There was a problem hiding this comment.
Please use boost::uint16_t instead of unsigned short.
|
Sorry about the back-and forth here, just a couple more things. |
|
OK done. |
|
LGTM -- thanks @DanielBujnik, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it is possible to set the TCP source port of HTTP and HTTPS client requests by calling setSourcePort method of client::request object.