MSVC fixes. Noexcept and =default for move. #449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Velho, Thanks for the effort but I won't merge these changes. The idea is that we are deprecating the macros that you are using in favour of using the noexcept, default, delete keywords explicitly. I know these aren't yet supported on any version of a Visual Studio compiler, but we are building the 1.0 version to be fully c++11 compatible. so far using GCC and Clang. This might sound frustrating to a Windows dev., but I expect this to change by the time MSVC 2014 comes around and we hope to support future versions of this compiler fully. Sorry if this is not helpful to you today, and I hope you will still be willing to contribute in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues with MSVC compiler. I used /DBOOST_NO_CXX11_DEFAULTED_FUNCTIONS to get correct preprocessors. Dont know if it should be added in CMake files under Win32 configurations.
Tested with MSVC 12.